Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test_uploads_and_deletions test #7758

Merged
merged 11 commits into from
May 15, 2024

Conversation

arpad-m
Copy link
Member

@arpad-m arpad-m commented May 14, 2024

Adds a test that is a reproducer for (now fixed) #7296 and also for #7707. Likely also for #7244 but I haven't tried that.

The key ordering bug can be reproduced by switching to merge_delta_keys instead of merge_delta_keys_buffered, so reverting a big part of #7661, although it only sometimes reproduces (30-50% of cases).

part of #7554

Copy link

github-actions bot commented May 14, 2024

3072 tests run: 2945 passed, 0 failed, 127 skipped (full report)


Flaky tests (1)

Postgres 16

  • test_hot_standby_gc: debug

Code coverage* (full report)

  • functions: 31.4% (6337 of 20187 functions)
  • lines: 47.4% (47914 of 101110 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
568e2a2 at 2024-05-15T13:26:18.967Z :recycle:

Copy link
Contributor

@problame problame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The def generate_uploads_and_deletions has been moved and not been modfied otherwise, right?

test_runner/regress/test_compaction.py Outdated Show resolved Hide resolved
test_runner/regress/test_compaction.py Outdated Show resolved Hide resolved
test_runner/regress/test_compaction.py Outdated Show resolved Hide resolved
Copy link
Contributor

@problame problame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Giving advance approval to unblock

arpad-m added 3 commits May 15, 2024 13:11
If the "assertion failed: self.lsn_range.start" assertion error
occurs, it will lead to a failing HTTP request, which
yields a panic in the pageserver, and a PageserverApiException
in the python test.
@arpad-m arpad-m requested a review from problame May 15, 2024 11:19
@arpad-m arpad-m merged commit 1075386 into main May 15, 2024
53 of 55 checks passed
@arpad-m arpad-m deleted the arpad/compaction_test_uploads_and_deletions branch May 15, 2024 13:32
a-masterov pushed a commit that referenced this pull request May 20, 2024
Adds a test that is a reproducer for many tiered compaction bugs,
both ones that have since been fixed as well as still unfxied ones:
* (now fixed) #7296 
* #7707 
* #7759
* Likely also #7244 but I haven't tried that.

The key ordering bug can be reproduced by switching to
`merge_delta_keys` instead of `merge_delta_keys_buffered`, so reverting
a big part of #7661, although it only sometimes reproduces (30-50% of
cases).

part of #7554
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants