-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test_uploads_and_deletions test #7758
Conversation
3072 tests run: 2945 passed, 0 failed, 127 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
568e2a2 at 2024-05-15T13:26:18.967Z :recycle: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The def generate_uploads_and_deletions
has been moved and not been modfied otherwise, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Giving advance approval to unblock
If the "assertion failed: self.lsn_range.start" assertion error occurs, it will lead to a failing HTTP request, which yields a panic in the pageserver, and a PageserverApiException in the python test.
Adds a test that is a reproducer for many tiered compaction bugs, both ones that have since been fixed as well as still unfxied ones: * (now fixed) #7296 * #7707 * #7759 * Likely also #7244 but I haven't tried that. The key ordering bug can be reproduced by switching to `merge_delta_keys` instead of `merge_delta_keys_buffered`, so reverting a big part of #7661, although it only sometimes reproduces (30-50% of cases). part of #7554
Adds a test that is a reproducer for (now fixed) #7296 and also for #7707. Likely also for #7244 but I haven't tried that.
The key ordering bug can be reproduced by switching to
merge_delta_keys
instead ofmerge_delta_keys_buffered
, so reverting a big part of #7661, although it only sometimes reproduces (30-50% of cases).part of #7554